There is no need to loop over all elements of a matrix checking if there are changes. Just stop at the first changed element. Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> Reported-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> --- drivers/media/v4l2-core/v4l2-ctrls.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index e8e2caa..23febc4 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++ b/drivers/media/v4l2-core/v4l2-ctrls.c @@ -1502,8 +1502,9 @@ static int cluster_changed(struct v4l2_ctrl *master) if (ctrl == NULL) continue; - for (idx = 0; idx < ctrl->rows * ctrl->cols; idx++) - ctrl_changed |= !ctrl->type_ops->equal(ctrl, idx, + for (idx = 0; !ctrl_changed && + idx < ctrl->rows * ctrl->cols; idx++) + ctrl_changed = !ctrl->type_ops->equal(ctrl, idx, ctrl->stores[0], ctrl->new); ctrl->has_changed = ctrl_changed; changed |= ctrl->has_changed; -- 1.8.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
