On Tue, 2014-02-11 at 22:41 +0200, Antti Palosaari wrote: > On 11.02.2014 22:32, Malcolm Priestley wrote: > > On Tue, 2014-02-11 at 19:42 +0200, Antti Palosaari wrote: > >> Moikka Malcolm! > >> Thanks for the patch serie. > >> > >> You removed all IDs from it913x driver. There is possibility to just > >> remove / comment out: > >> MODULE_DEVICE_TABLE(usb, it913x_id_table); > >> which prevents loading that driver automatically, but leaves possibility > >> to load it manually if user wants to fallback. I am fine either way you > >> decide to do it, just a propose. > > Hi Antti > > > > I am going post a patches to remove it. > > > > The only reason why an user would want to fall back is > > the use dvb-usb-it9137-01.fw firmware with USB_VID_KWORLD_2. > > > > I left the USB_VID_KWORLD_2 ids in the driver. > > > > I haven't found any issues with dvb-usb-it9135-01.fw > > > > USB_VID_KWORLD_2 users could have trouble updating older kernels via > > media_build. > > > > Perhaps there should be a warning message in af9035 that users need to > > change firmware. > > Is that KẂorld device dual model (I guess yes, because of it9137)? Is it > version 1 (AX) or version 2 (BX) chip? Both apparently exist, but the firmware is the same. The main difference registers in the firmwares dvb-usb-it9137-01.fw -->clk enable 0xd81a --> tuner_it91x_priv.h...set_it9137_template dvb-usb-it9135-01.fw -->clk enable 0xcfff --> tuner_it91x_priv.h...set_it9135_template dvb-usb-it9135-02.fw -->clk enable 0xcfff --> tuner_it91x_priv.h...set_it9135_template As far as It can tell all the latest firmwares are based on set_it9135_template. On the KWorld the second device is another it9137 and has an eeprom 24c02 fitted. So dropping the dvb-usb-it9137-01.fw firmware is fine. Regards Malcolm -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
