Hi Hans,
On Tuesday 11 February 2014 11:19:32 Hans Verkuil wrote:
> On 02/05/14 17:42, Laurent Pinchart wrote:
> > The ADV7604 has sink pads for its HDMI and analog inputs. Report them.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> >
> > drivers/media/i2c/adv7604.c | 71 +++++++++++++++++++++++++---------------
> > include/media/adv7604.h | 14 ---------
> > 2 files changed, 45 insertions(+), 40 deletions(-)
> >
> > diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> > index 05e7e1a..da32ce9 100644
> > --- a/drivers/media/i2c/adv7604.c
> > +++ b/drivers/media/i2c/adv7604.c
> > @@ -97,13 +97,25 @@ struct adv7604_chip_info {
> >
> > **********************************************************************
> > */
> >
> > +enum adv7604_pad {
> > + ADV7604_PAD_HDMI_PORT_A = 0,
> > + ADV7604_PAD_HDMI_PORT_B = 1,
> > + ADV7604_PAD_HDMI_PORT_C = 2,
> > + ADV7604_PAD_HDMI_PORT_D = 3,
> > + ADV7604_PAD_VGA_RGB = 4,
> > + ADV7604_PAD_VGA_COMP = 5,
> > + /* The source pad is either 1 (ADV7611) or 6 (ADV7604) */
>
> How about making this explicit:
>
> ADV7604_PAD_SOURCE = 6,
> ADV7611_PAD_SOURCE = 1,
I can do that, but those two constants won't be used in the driver as they
computed dynamically.
> > + ADV7604_PAD_MAX = 7,
> > +};
>
> Wouldn't it make more sense to have this in the header? I would really
> like to use the symbolic names for these pads in my bridge driver.
That would add a dependency on the adv7604 driver to the bridge driver, isn't
the whole point of subdevs to avoid such dependencies ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
