Hi Hans, Thanks for the update. On Fri, Feb 07, 2014 at 03:10:34PM +0100, Hans Verkuil wrote: ... > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > index d67210a..84b7cce 100644 > --- a/include/media/v4l2-subdev.h > +++ b/include/media/v4l2-subdev.h > @@ -162,6 +162,9 @@ struct v4l2_subdev_core_ops { > int (*g_std)(struct v4l2_subdev *sd, v4l2_std_id *norm); > int (*s_std)(struct v4l2_subdev *sd, v4l2_std_id norm); > long (*ioctl)(struct v4l2_subdev *sd, unsigned int cmd, void *arg); > +#ifdef CONFIG_COMPAT > + long (*compat_ioctl32)(struct v4l2_subdev *sd, unsigned int cmd, unsigned long arg); I'd wrap this. I can understanding not wrapping lines in IOCTL definitions but I see much less reason to do so here. > +#endif > #ifdef CONFIG_VIDEO_ADV_DEBUG > int (*g_register)(struct v4l2_subdev *sd, struct v4l2_dbg_register *reg); > int (*s_register)(struct v4l2_subdev *sd, const struct v4l2_dbg_register *reg); Tested-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html