Hi Laurent, Thanks for the patch. On Wed, Feb 05, 2014 at 05:42:18PM +0100, Laurent Pinchart wrote: ... > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c > index 996c248..0ccf9c8 100644 > --- a/drivers/media/v4l2-core/v4l2-subdev.c > +++ b/drivers/media/v4l2-core/v4l2-subdev.c > @@ -354,6 +354,21 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg) > > case VIDIOC_SUBDEV_S_EDID: > return v4l2_subdev_call(sd, pad, set_edid, arg); > + > + case VIDIOC_SUBDEV_DV_TIMINGS_CAP: > + return v4l2_subdev_call(sd, pad, dv_timings_cap, arg); > + > + case VIDIOC_SUBDEV_ENUM_DV_TIMINGS: > + return v4l2_subdev_call(sd, pad, enum_dv_timings, arg); > + > + case VIDIOC_SUBDEV_QUERY_DV_TIMINGS: > + return v4l2_subdev_call(sd, video, query_dv_timings, arg); > + > + case VIDIOC_SUBDEV_G_DV_TIMINGS: > + return v4l2_subdev_call(sd, video, g_dv_timings, arg); > + > + case VIDIOC_SUBDEV_S_DV_TIMINGS: > + return v4l2_subdev_call(sd, video, s_dv_timings, arg); Please validate the fields of the argument structs above you can. The pad field at least can be validated. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html