Hi Hans,
Please ignore and reject this patch. videobuf_queue_vmalloc_init needs
to be in probe, not in open.
Let me know your thoughts on doing videobuf2 before s2255_fh removal so
we don't have to work around or fix videobuf version one's deficiencies.
Thanks,
On 2014-02-04 16:36, Dean Anderson wrote:
Removes most parameters from s2255_fh. These elements belong in
s2255_ch.
In the future, s2255_fh will be removed when videobuf2 is used.
videobuf2
has convenient and safe functions for locking streaming resources.
The removal of s2255_fh (and s2255_fh->resources) was not done now to
avoid using videobuf_queue_is_busy.
videobuf_queue_is busy may be unsafe as noted by the following comment
in videobuf-core.c:
"/* Locking: Only usage in bttv unsafe find way to remove */"
Signed-off-by: Dean Anderson <linux-dev@xxxxxxxxxxxx>
---
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
