Hi Hans,
Thanks for the patchset!
On Mon, Jan 20, 2014 at 01:45:55PM +0100, Hans Verkuil wrote:
> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> index 0b347e8..3998049 100644
> --- a/include/media/v4l2-ctrls.h
> +++ b/include/media/v4l2-ctrls.h
> @@ -85,6 +85,7 @@ typedef void (*v4l2_ctrl_notify_fnc)(struct v4l2_ctrl *ctrl, void *priv);
> * @ops: The control ops.
> * @id: The control ID.
> * @name: The control name.
> + * @unit: The control's unit. May be NULL.
> * @type: The control type.
> * @minimum: The control's minimum value.
> * @maximum: The control's maximum value.
> @@ -130,6 +131,7 @@ struct v4l2_ctrl {
> const struct v4l2_ctrl_ops *ops;
> u32 id;
> const char *name;
> + const char *unit;
What would you think of using a numeric value (with the standardised units
#defined)? I think using a string begs for unmanaged unit usage. Code that
deals with units might work with one driver but not with another since it
uses a slightly different string for unit x.
A prefix could be potentially nice, too, so ms and µs would still have the
same unit but a different prefix.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
