On 21 January 2014 14:28, Sean Young <sean@xxxxxxxx> wrote: > On Mon, Jan 20, 2014 at 09:39:43PM +0200, Antti Seppälä wrote: >> This patch series introduces a simple sysfs file interface for reading >> and writing wakeup scancodes to rc drivers. >> >> This is an improved version of my previous patch for nuvoton-cir which >> did the same thing via module parameters. This is a more generic >> approach allowing other drivers to utilize the interface as well. >> >> I did not port winbond-cir to this method of wakeup scancode setting yet >> because I don't have the hardware to test it and I wanted first to get >> some comments about how the patch series looks. I did however write a >> simple support to read and write scancodes to rc-loopback module. > > Doesn't the nuvoton-cir driver need to know the IR protocol for wakeup? > > This is needed for winbond-cir; I guess this should be another sysfs > file, something like "wakeup_protocol". Even if the nuvoton can only > handle one IR protocol, maybe it should be exported (readonly) via > sysfs? > > I'm happy to help with a winbond-cir implementation; I have the hardware. > > > Sean Nuvoton-cir doesn't care about the IR protocol because the hardware compares raw IR pulse lengths and wakes the system if received pulse is within certain tolerance of the one pre-programmed to the HW. This approach is agnostic to the used IR protocol. I glanced over the winbond-cir driver and porting the driver to use sysfs for wakeup scancodes looks doable. Also a new sysfs entry for setting the wakeup protocol would indeed be needed... I will take a closer look at this when I have some more time. -Antti -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
