Em Tue, 14 Jan 2014 17:55:19 +0200 Georgi Chorbadzhiyski <gf@xxxxxxxxxxx> escreveu: > Around 01/14/2014 05:30 PM, Mauro Carvalho Chehab scribbled: > > Em Tue, 14 Jan 2014 17:16:10 +0200 > > Georgi Chorbadzhiyski <gf@xxxxxxxxxxx> escreveu: > > > >> Hi guys, I'm confused the documentation on: > >> > >> http://linuxtv.org/downloads/v4l-dvb-apis/frontend_fcalls.html#FE_READ_SNR > >> http://linuxtv.org/downloads/v4l-dvb-apis/frontend_fcalls.html#FE_READ_SIGNAL_STRENGTH > >> > >> states that these ioctls return int16_t values but frontend.h states: > >> > >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/dvb/frontend.h > >> > >> #define FE_READ_SIGNAL_STRENGTH _IOR('o', 71, __u16) > >> #define FE_READ_SNR _IOR('o', 72, __u16) > >> > >> So which one is true? > > > > Documentation is wrong. The returned values are unsigned. Would you mind send > > us a patch fixing it? > > I would be happy to, but I can't find the repo that holds the documentation. It is in the Kernel tree, under Documentation/DocBook/media/dvb. > > > Btw, the better is to use the new statistics API, when it is > > available: > > http://linuxtv.org/downloads/v4l-dvb-apis/FE_GET_SET_PROPERTY.html#frontend-stat-properties > > > > As it properly specifies the scale of each value. > > When it's ready, I'll add support for the API in dvblast. Good. -- Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
