Re: [PATCH 09/18] libdvbv5: implement ATSC EIT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +void atsc_table_eit_init(struct dvb_v5_fe_parms *parms, const uint8_t *buf, ssize_t buflen, uint8_t *table, ssize_t *table_length)
> > +{
> > +	const uint8_t *p = buf;
> > +	struct atsc_table_eit *eit = (struct atsc_table_eit *) table;
> > +	struct atsc_table_eit_event **head;
> > +
> > +	if (*table_length > 0) {
> > +		memcpy(eit, p, sizeof(struct atsc_table_eit) - sizeof(eit->event));
> 
> Hmm... on some patches, when the table already exists, nothing is copied.
> 
> Just the pointer 'p' is incremented.
> 
> We should standardize this. Not sure what's the better.

agree. the first implementations were ok not copying already existing
table bodies. but tables like the EIT need info from the table body in
every section, so we need to parse that...

I will fix this for all tables in a later patch.

Regards,
 andré
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux