Re: [media] Add driver for Samsung S5K5BAF camera sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dan,

On 8 January 2014 14:39, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> Hello Andrzej Hajda,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 7d459937dc09: "[media] Add driver for Samsung S5K5BAF
> camera sensor" from Dec 5, 2013, leads to the following Smatch
> complaint:
>
> drivers/media/i2c/s5k5baf.c:554 s5k5baf_fw_get_seq()
>          warn: variable dereferenced before check 'fw' (see line 551)
>
> drivers/media/i2c/s5k5baf.c
>    550          struct s5k5baf_fw *fw = state->fw;
>    551          u16 *data = fw->data + 2 * fw->count;
>                                            ^^^^^^^^^
> Dereference.
>
>    552          int i;
>    553
>    554          if (fw == NULL)
>                     ^^^^^^^^^^
> Check.
>
>    555                  return NULL;
>    556
>

A patch [1] to fix this has already been queued up by Mauro.

[1] https://linuxtv.org/patch/21292/

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux