Em Mon, 06 Jan 2014 08:01:31 -0200 Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx> escreveu: > When xc2028/3028 is powered down, it won't response to any command, until > a firmware is loaded. That means that reading frontend status will fail > with a timeout. > > Also, any trial to put the device to sleep twice will fail. > > This small series fix those two bugs. > > Mauro Carvalho Chehab (2): > tuner-xc2028: Don't try to sleep twice > tuner-xc2028: Don't read status if device is powered down > > drivers/media/tuners/tuner-xc2028.c | 29 ++++++++++++++++++++++++++--- > 1 file changed, 26 insertions(+), 3 deletions(-) > It turns that the errors I was experiencing with tvp5150 on HVR-950 seem to be a reflex of the xc3028 errors, as they disappeared after this fix. I suspect that the tvp5150 reads were sent too fast to em28xx, while it was still trying to do a read on the powered down xc3028. That could likely mean that the code at em28xx I2C read would need to wait for a longer time, or that we may need to send an ACK to em28xx I2C, via register 0x06 bit 7. Anyway, as everything is working fine, I'm just dropping the I2C retry logic. I don't intend to work on any other fixup patch for I2C. However, as the bug seems to still be hidden somewhere there, better to have an option to turn on debug messages for timeouts. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
