[PATCH] xc2028: disable device power-down because power state handling is broken

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



xc2028 power state handling is broken.
I2C read/write operations fail when the device is powered down at that moment,
which causes the get_rf_strength and get_rf_strength callbacks (and probably
others, too) to fail.
I don't know how to fix this properly, so disable the device power-down until
anyone comes up with a better solution.

Signed-off-by: Frank Schäfer <fschaefer.oss@xxxxxxxxxxxxxx>
---
 drivers/media/tuners/tuner-xc2028.c |    4 +++-
 1 Datei geändert, 3 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)

diff --git a/drivers/media/tuners/tuner-xc2028.c b/drivers/media/tuners/tuner-xc2028.c
index 4be5cf8..cb3dc5e 100644
--- a/drivers/media/tuners/tuner-xc2028.c
+++ b/drivers/media/tuners/tuner-xc2028.c
@@ -1291,16 +1291,18 @@ static int xc2028_sleep(struct dvb_frontend *fe)
 		dump_stack();
 	}
 
+	/* FIXME: device power-up/-down handling is broken */
+/*
 	mutex_lock(&priv->lock);
 
 	if (priv->firm_version < 0x0202)
 		rc = send_seq(priv, {0x00, XREG_POWER_DOWN, 0x00, 0x00});
 	else
 		rc = send_seq(priv, {0x80, XREG_POWER_DOWN, 0x00, 0x00});
-
 	priv->state = XC2028_SLEEP;
 
 	mutex_unlock(&priv->lock);
+*/
 
 	return rc;
 }
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux