On 17.12.2013 09:34, Hans Verkuil wrote:
On 12/16/2013 11:08 PM, Antti Palosaari wrote:+ } else if (is_sdr) {
+ + if (is_rx) { + SET_VALID_IOCTL(ops, VIDIOC_ENUMINPUT, vidioc_enum_input); + SET_VALID_IOCTL(ops, VIDIOC_G_INPUT, vidioc_g_input); + SET_VALID_IOCTL(ops, VIDIOC_S_INPUT, vidioc_s_input);Why would you want to enable these? Normal radio devices should never use these, so why would sdr devices?
I though it might be good idea to select possible antenna input. I have one rtl2832u prototype which has 2 physical antenna connector, but on the real life input selection is not needed even on that case as antennas are hardwired to different tuner inputs => selection is done according to frequency. Almost all modern silicon tuners has multiple inputs, whilst device has only one physical antenna connector.
All-in-all, it is not needed now and I can remove it without any noise if you wish. It is trivial to add later if really needed.
regards Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
