On 12/12/2013 06:12 PM, Antti Palosaari wrote: > On 12.12.2013 09:50, Hans Verkuil wrote: >> On 12/12/2013 12:54 AM, Antti Palosaari wrote: >>> Define tuner types V4L2_TUNER_ADC and V4L2_TUNER_SDR for SDR usage. >>> >>> ADC is used for setting sampling rate (sampling frequency) to SDR >>> device. >>> >>> Another tuner type, SDR, is possible RF tuner. Is is used to >>> down-convert RF frequency to range ADC could sample. It is optional >>> for SDR device. >>> >>> Also add checks to VIDIOC_G_FREQUENCY, VIDIOC_S_FREQUENCY and >>> VIDIOC_ENUM_FREQ_BANDS only allow these two tuner types when device >>> type is SDR (VFL_TYPE_SDR). >> >> Shouldn't you also adapt s_hw_freq_seek? > > nope! I don't see how SDR could do hardware seek as demodulator is > needed to make decision if radio channel is valid or not. On SDR > receiver that demodulator is implemented by application software, DSP, > thus name software defined radio. > > Maybe it could be mapped to signal strength measurement, but it is > another story to think. Fair enough, but in that case I would add: /* s_hw_freq_seek is not supported for SDR for now */ if (vfd->vfl_type == VFL_TYPE_SDR) return -EINVAL; at the beginning of v4l_s_hw_freq_seek(). Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
