v4l-utils-1.0.0 bug report

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello there,

I just ran the static analysis tool "cppcheck" over the
source code of v4l-utils-1.0.0. It said many things, including

1. [rds-saa6588.c:119]: (style) Expression '(X & 0x8) == 0x1' is always false.

Source code is

    if (1 == (b[0] & 0x08)) {

Maybe the programmer intended

    if (0 != (b[0] & 0x08)) {

2.[rds-saa6588.c:122]: (style) Expression '(X & 0x4) == 0x1' is always false.

Source code is

   if (1 == (b[0] & 0x04)) {

Duplicate.

Regards

David Binderman 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux