Re: [PATCH v3] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lisa,

Thank you for the patch.

On Tuesday 10 December 2013 22:09:22 Lisa Nguyen wrote:
> Rewrite the return statement in vpfe_video.c. This will prevent
> the checkpatch.pl script from generating a warning saying
> to remove () from this particular return statement.
> 
> Signed-off-by: Lisa Nguyen <lisa@xxxxxxxxxxxxxxx>

Acked-by; Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> Changes since v3:
> - Removed () from return statement per Laurent Pinchart's suggestion
> 
>  drivers/staging/media/davinci_vpfe/vpfe_video.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> b/drivers/staging/media/davinci_vpfe/vpfe_video.c index 24d98a6..3b036be
> 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> @@ -346,7 +346,7 @@ static int vpfe_pipeline_disable(struct vpfe_pipeline
> *pipe) }
>  	mutex_unlock(&mdev->graph_mutex);
> 
> -	return (ret == 0) ? ret : -ETIMEDOUT ;
> +	return ret ? -ETIMEDOUT : 0;
>  }
> 
>  /*
-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux