Em Mon, 09 Dec 2013 17:17:41 +0100
Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
> On 12/09/2013 04:51 PM, Mauro Carvalho Chehab wrote:
> > Em Fri, 6 Dec 2013 11:17:14 +0100
> > Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
> >
> >> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> >>
> >> Fix most checkpatch errors/warnings.
> >>
> >> It's mostly whitespace changes, except for replacing msleep with
> >> usleep_range and the jiffies comparison with time_is_after_jiffies().
> >>
> >> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> >> ---
> >> drivers/media/radio/si4713/radio-usb-si4713.c | 4 +-
> >> drivers/media/radio/si4713/si4713.c | 104 +++++++++++++-------------
> >> 2 files changed, 55 insertions(+), 53 deletions(-)
> >>
> >> diff --git a/drivers/media/radio/si4713/radio-usb-si4713.c b/drivers/media/radio/si4713/radio-usb-si4713.c
> >> index d978844..691e487 100644
> >> --- a/drivers/media/radio/si4713/radio-usb-si4713.c
> >> +++ b/drivers/media/radio/si4713/radio-usb-si4713.c
> >> @@ -207,7 +207,7 @@ static int si4713_send_startup_command(struct si4713_usb_device *radio)
> >> }
> >> if (time_is_before_jiffies(until_jiffies))
> >> return -EIO;
> >> - msleep(3);
> >> + usleep_range(3000, 5000);
> >> }
> >>
> >> return retval;
> >> @@ -354,7 +354,7 @@ static int si4713_i2c_read(struct si4713_usb_device *radio, char *data, int len)
> >> data[0] = 0;
> >> return 0;
> >> }
> >> - msleep(3);
> >> + usleep_range(3000, 5000);
> >> }
> >> }
> >>
> >> diff --git a/drivers/media/radio/si4713/si4713.c b/drivers/media/radio/si4713/si4713.c
> >> index 6f28a2b..451b9c0 100644
> >> --- a/drivers/media/radio/si4713/si4713.c
> >> +++ b/drivers/media/radio/si4713/si4713.c
> >> @@ -50,12 +50,12 @@ MODULE_VERSION("0.0.1");
> >> #define DEFAULT_RDS_PS_REPEAT_COUNT 0x0003
> >> #define DEFAULT_LIMITER_RTIME 0x1392
> >> #define DEFAULT_LIMITER_DEV 0x102CA
> >> -#define DEFAULT_PILOT_FREQUENCY 0x4A38
> >> +#define DEFAULT_PILOT_FREQUENCY 0x4A38
> >> #define DEFAULT_PILOT_DEVIATION 0x1A5E
> >> #define DEFAULT_ACOMP_ATIME 0x0000
> >> #define DEFAULT_ACOMP_RTIME 0xF4240L
> >> #define DEFAULT_ACOMP_GAIN 0x0F
> >> -#define DEFAULT_ACOMP_THRESHOLD (-0x28)
> >> +#define DEFAULT_ACOMP_THRESHOLD (-0x28)
> >> #define DEFAULT_MUTE 0x01
> >> #define DEFAULT_POWER_LEVEL 88
> >> #define DEFAULT_FREQUENCY 8800
> >> @@ -252,8 +252,8 @@ static int si4713_send_command(struct si4713_device *sdev, const u8 command,
> >>
> >> if (client->irq)
> >> return -EBUSY;
> >> - msleep(1);
> >> - } while (jiffies <= until_jiffies);
> >> + usleep_range(1000, 2000);
> >> + } while (time_is_after_jiffies(until_jiffies));
> >
> > Condition seems to be wrong here: it should be time_is_before_jiffies().
>
> No, the condition is good. 'time_is_after_jiffies(until_jiffies)' means
> 'until_jiffies > jiffies' which is 'jiffies <= until_jiffies'.
Ah, yeah, this one is correct.
Those macro names sound a little confusing :)
>
> > Also, the better is to put this on a separate patch.
>
> OK.
>
> Regards,
>
> Hans
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
