Re: [PATCH] [media] radio-shark: Mark shark_resume_leds() inline to kill compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 10/28/2013 01:16 PM, Geert Uytterhoeven wrote:
If SHARK_USE_LEDS=1, but CONFIG_PM=n:

drivers/media/radio/radio-shark.c:275: warning: ‘shark_resume_leds’ defined but not used

Instead of making the #ifdef logic even more complicated (there are already
two definitions of shark_resume_leds()), mark shark_resume_leds() inline to
kill the compiler warning. shark_resume_leds() is small and it has only one
caller.

Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
---
{cris,m68k,parisc,sparc,xtensa}-all{mod,yes}config

  drivers/media/radio/radio-shark.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/radio/radio-shark.c b/drivers/media/radio/radio-shark.c
index b91477212413..050b3bb96fec 100644
--- a/drivers/media/radio/radio-shark.c
+++ b/drivers/media/radio/radio-shark.c
@@ -271,7 +271,7 @@ static void shark_unregister_leds(struct shark_device *shark)
  	cancel_work_sync(&shark->led_work);
  }

-static void shark_resume_leds(struct shark_device *shark)
+static inline void shark_resume_leds(struct shark_device *shark)
  {
  	if (test_bit(BLUE_IS_PULSE, &shark->brightness_new))
  		set_bit(BLUE_PULSE_LED, &shark->brightness_new);


Thanks for the patch. I've added this to my tree for 3.13 .

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux