On Tue, Nov 5, 2013 at 5:30 PM, ほち <knightrider@xxxxxx> wrote: > Michael Krufky <mkrufky <at> linuxtv.org> writes: > >> As the DVB maintainer, I am telling you that I won't merge this as a >> monolithic driver. The standard is to separate the driver into >> modules where possible, unless there is a valid reason for doing >> otherwise. >> >> I understand that you used the PT1 driver as a reference, but we're >> trying to enforce a standard of codingstyle within the kernel. I >> recommend looking at the other DVB drivers as well. > > OK Sir. Any good / latest examples? There are plenty of DVB drivers to look at under drivers/media/ ... you may notice that there are v4l and dvb device drivers together under this hierarchy. It's easy to tell which drivers support DVB when you look at the source. I could name a few specific ones, but i'd really recommend for you to take a look at a bunch of them. No single driver should be considered a 'prefect example' as they are all under constant maintenance. Also, many of these drivers are for devices that support both v4l and DVB interfaces. One example is the cx23885 driver. Still, please try to look over the entire media tree, as that would give a better idea of how the drivers are structured. Best regards, Mike Krufky -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html