On Mon, Nov 04, 2013 at 02:17:53PM +0100, Laurent Pinchart wrote: > > That return value will end up to at least one place which seems to be > > isp_video_streamon() and, unless I'm mistaken, will cause > > ioctl(VIDIOC_STREAMON) also return ENOTTY. > > I should have split this in two patches, or at least explained the rationale > in the commit message. The remote subdev is always an internal ISP subdev, the > pad::get_fmt operation is thus guaranteed to be implemented. There's no need > to check for ENOIOCTLCMD. Right; true. If you add an explanation on that to the commit message (which I think is much less self-evident than access to the local struct not requiring serialisation), Acked-by: Sakari Ailus <sakari.ailus@xxxxxx> -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
