Hi Lisa, Thanks for the patch. On Tue, Oct 29, 2013 at 2:53 AM, Lisa Nguyen <lisa@xxxxxxxxxxxxxxx> wrote: > Rewrite the return statement in vpfe_video.c to eliminate the > use of a ternary operator. This will prevent the checkpatch.pl > script from generating a warning saying to remove () from > this particular return statement. > > Signed-off-by: Lisa Nguyen <lisa@xxxxxxxxxxxxxxx> > --- > drivers/staging/media/davinci_vpfe/vpfe_video.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c > index 24d98a6..49aafe4 100644 > --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c > +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c > @@ -346,7 +346,10 @@ static int vpfe_pipeline_disable(struct vpfe_pipeline *pipe) > } > mutex_unlock(&mdev->graph_mutex); > > - return (ret == 0) ? ret : -ETIMEDOUT ; > + if (ret == 0) > + return ret; > + else I would remove this else and align the below return statement. > + return -ETIMEDOUT; > } > > /* Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
