On 27/09/13 12:59, Arun Kumar K wrote: > This patch adds subdev driver for Samsung S5K4E5 raw image sensor. > Like s5k6a3, it is also another fimc-is firmware controlled > sensor. This minimal sensor driver doesn't do any I2C communications > as its done by ISP firmware. It can be updated if needed to a > regular sensor driver by adding the I2C communication. > > Signed-off-by: Arun Kumar K <arun.kk@xxxxxxxxxxx> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > --- > .../devicetree/bindings/media/i2c/s5k4e5.txt | 45 +++ > drivers/media/i2c/Kconfig | 8 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/s5k4e5.c | 347 ++++++++++++++++++++ > 4 files changed, 401 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/s5k4e5.txt > create mode 100644 drivers/media/i2c/s5k4e5.c > > diff --git a/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt > new file mode 100644 > index 0000000..0fca087 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt Could you make a separate patch adding DT binding only ? And can you please rename this file to: Documentation/devicetree/bindings/media/samsung-s5k4e5.txt, like it's done in case of other sensors ? Should I apply patches 02...11/13 already or would you like send the whole series updated ? AFAICS there are minor things pointed out by Hans not addressed yet ? Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
