On 10/14/2013 02:28 PM, Mauro Carvalho Chehab wrote:
Sylwester Nawrocki (1): v4l2-ctrls: Correct v4l2_ctrl_get_int_menu() function prototypeThis patch is wrong or incomplete, as it calls hundreds of warnings (see below). I'll just drop it: $ make ARCH=i386 CONFIG_DEBUG_SECTION_MISMATCH=y W=1 M=drivers/staging/media WARNING: Symbol version dump /devel/v4l/patchwork/Module.symvers is missing; modules will have no dependencies and modversions. In file included from include/media/v4l2-subdev.h:28:0, from include/media/v4l2-device.h:25, from drivers/staging/media/go7007/s2250-board.c:24: include/media/v4l2-common.h:89:19: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] const s64 * const v4l2_ctrl_get_int_menu(u32 id, u32 *len);
Yes, it rightfully does so, since even if the pointer is const, it will still be modifiable, due to pass-by-value language conventions. Sorry for wasting your time with that crappy patch, I'll post a new one with the second 'const' removed. Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
