On Sat, Oct 12, 2013 at 4:54 AM, Luis Alves <ljalvs@xxxxxxxxx> wrote: > Hi, > > On this patch: > Added a few defines to describe what every constant in the set_voltage function. > Added the description to the CX24117 GPIO control commands. > Moved the GPIODIR setup to the initfe function. Luis, It is generally not preferred to send multiple changes in a single patch, even if the changes themselves are small. I know it's not such a huge patch, but, it is preferred for each patch to contain only one single change, provided that the patch remains atomic in nature. I don't think it would be such a problem to merge these changes as-is, but I do think it would be better to try to enforce the idea of "one change per atomic patch" when possible. Can you re-spin this into two (or three) smaller patches? The first patch should handle the cosmetics, "Added a few defines to describe every constant in the set_voltage function" & "Added the description to the CX24117 GPIO control commands" ... As you see, these two bits change the code slightly but do not alter the behavior of the driver. The final patch should be the one that does alter the driver's behavior, "Moved the GPIODIR setup to the initfe function" Doing this can potentially help to quicken the review & merge process, while also enhancing the readability of the change history within the kernel. Cheers, Mike Krufky -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
