Re: [PATCH 05/14] cxd2820r_core: fix sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 4, 2013 at 10:36 AM, Antti Palosaari <crope@xxxxxx> wrote:
> On 04.10.2013 17:01, Hans Verkuil wrote:
>>
>> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>>
>> drivers/media/dvb-frontends/cxd2820r_core.c:34:32: error: cannot size
>> expression
>> drivers/media/dvb-frontends/cxd2820r_core.c:68:32: error: cannot size
>> expression
>>
>> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>
>
> Acked-by: Antti Palosaari <crope@xxxxxx>
> Reviewed-by: Antti Palosaari <crope@xxxxxx>
>
>
>
>> Cc: Antti Palosaari <crope@xxxxxx>
>> ---
>>   drivers/media/dvb-frontends/cxd2820r_core.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/dvb-frontends/cxd2820r_core.c
>> b/drivers/media/dvb-frontends/cxd2820r_core.c
>> index 7ca5c69..d9eeeb1 100644
>> --- a/drivers/media/dvb-frontends/cxd2820r_core.c
>> +++ b/drivers/media/dvb-frontends/cxd2820r_core.c
>> @@ -31,7 +31,7 @@ static int cxd2820r_wr_regs_i2c(struct cxd2820r_priv
>> *priv, u8 i2c, u8 reg,
>>                 {
>>                         .addr = i2c,
>>                         .flags = 0,
>> -                       .len = sizeof(buf),
>> +                       .len = len + 1,
>>                         .buf = buf,
>>                 }
>>         };
>> @@ -65,7 +65,7 @@ static int cxd2820r_rd_regs_i2c(struct cxd2820r_priv
>> *priv, u8 i2c, u8 reg,
>>                 }, {
>>                         .addr = i2c,
>>                         .flags = I2C_M_RD,
>> -                       .len = sizeof(buf),
>> +                       .len = len,
>>                         .buf = buf,
>>                 }
>>         };
>>
>
>
> --
> http://palosaari.fi/
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reviewed-by: Michael Krufky <mkrufky@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux