Re: Subject: [PATCH 2/2] [media] r820t: simplify divisor calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jiří,

It's difficult to understand a patch like this, let alone merging it,
without any kind of explanation.  At a quick glance, the patch looks
wrong.  If you believe the patch is correct, then please resubmit with
some sort of description and explanation for the change.

Best regards,

Mike Krufky

On Sun, Sep 29, 2013 at 6:46 AM, Jiří Pinkava <j-pi@xxxxxxxxx> wrote:
>
> ---
>  drivers/media/tuners/r820t.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
> index e25c720..36dc63e 100644
> --- a/drivers/media/tuners/r820t.c
> +++ b/drivers/media/tuners/r820t.c
> @@ -596,13 +596,9 @@ static int r820t_set_pll(struct r820t_priv *priv,
> enum v4l2_tuner_type type,
>         while (mix_div <= 64) {
>                 if (((freq * mix_div) >= vco_min) &&
>                    ((freq * mix_div) < vco_max)) {
> -                       div_buf = mix_div;
> -                       while (div_buf > 2) {
> -                               div_buf = div_buf >> 1;
> -                               div_num++;
> -                       }
>                         break;
>                 }
> +               ++div_num;
>                 mix_div = mix_div << 1;
>         }
>
> --
> 1.8.3.2
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux