Re: [PATCH] [media] stk1135: fix two warnings added by changeset 76e0598

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/26/2013 12:42 PM, Mauro Carvalho Chehab wrote:
> drivers/media/usb/gspca/stk1135.c:615:6: warning: no previous prototype for 'stk1135_try_fmt' [-Wmissing-prototypes]
>  void stk1135_try_fmt(struct gspca_dev *gspca_dev, struct v4l2_format *fmt)
>       ^
> drivers/media/usb/gspca/stk1135.c:627:5: warning: no previous prototype for 'stk1135_enum_framesizes' [-Wmissing-prototypes]
>  int stk1135_enum_framesizes(struct gspca_dev *gspca_dev,
> 
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>

Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>

Regards,

	Hans

> ---
>  drivers/media/usb/gspca/stk1135.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/usb/gspca/stk1135.c b/drivers/media/usb/gspca/stk1135.c
> index 8add2f7..1fc80af 100644
> --- a/drivers/media/usb/gspca/stk1135.c
> +++ b/drivers/media/usb/gspca/stk1135.c
> @@ -612,7 +612,7 @@ static int sd_init_controls(struct gspca_dev *gspca_dev)
>  	return 0;
>  }
>  
> -void stk1135_try_fmt(struct gspca_dev *gspca_dev, struct v4l2_format *fmt)
> +static void stk1135_try_fmt(struct gspca_dev *gspca_dev, struct v4l2_format *fmt)
>  {
>  	fmt->fmt.pix.width = clamp(fmt->fmt.pix.width, 32U, 1280U);
>  	fmt->fmt.pix.height = clamp(fmt->fmt.pix.height, 32U, 1024U);
> @@ -624,7 +624,7 @@ void stk1135_try_fmt(struct gspca_dev *gspca_dev, struct v4l2_format *fmt)
>  	fmt->fmt.pix.sizeimage = fmt->fmt.pix.width * fmt->fmt.pix.height;
>  }
>  
> -int stk1135_enum_framesizes(struct gspca_dev *gspca_dev,
> +static int stk1135_enum_framesizes(struct gspca_dev *gspca_dev,
>  			struct v4l2_frmsizeenum *fsize)
>  {
>  	if (fsize->index != 0 || fsize->pixel_format != V4L2_PIX_FMT_SBGGR8)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux