On 09/19/2013 11:13 AM, Philipp Zabel wrote:
> The register is only written on CodaDx6, so the temporary variable
> to be written only needs to be initialized on CodaDx6.
>
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> ---
> drivers/media/platform/coda.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
> index 53539c1..e8acff3 100644
> --- a/drivers/media/platform/coda.c
> +++ b/drivers/media/platform/coda.c
> @@ -2074,10 +2074,10 @@ static int coda_start_streaming(struct vb2_queue *q, unsigned int count)
> coda_setup_iram(ctx);
>
> if (dst_fourcc == V4L2_PIX_FMT_H264) {
> - value = (FMO_SLICE_SAVE_BUF_SIZE << 7);
> - value |= (0 & CODA_FMOPARAM_TYPE_MASK) << CODA_FMOPARAM_TYPE_OFFSET;
> - value |= 0 & CODA_FMOPARAM_SLICENUM_MASK;
> if (dev->devtype->product == CODA_DX6) {
> + value = (FMO_SLICE_SAVE_BUF_SIZE << 7);
> + value |= (0 & CODA_FMOPARAM_TYPE_MASK) << CODA_FMOPARAM_TYPE_OFFSET;
> + value |= 0 & CODA_FMOPARAM_SLICENUM_MASK;
0 & CODA_FMOPARAM_SLICENUM_MASK?
These last two lines evaluate to a nop, so that looks very weird. Is this a bug?
Regards,
Hans
> coda_write(dev, value, CODADX6_CMD_ENC_SEQ_FMO);
> } else {
> coda_write(dev, ctx->iram_info.search_ram_paddr,
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
