On Sep 22 Govindarajulu Varadarajan wrote:
> Signed-off-by: Govindarajulu Varadarajan <govindarajulu90@xxxxxxxxx>
> ---
> drivers/media/firewire/firedtv-avc.c | 41 ------------------------------------
> 1 file changed, 41 deletions(-)
>
> diff --git a/drivers/media/firewire/firedtv-avc.c b/drivers/media/firewire/firedtv-avc.c
> index d1a1a13..786e273 100644
> --- a/drivers/media/firewire/firedtv-avc.c
> +++ b/drivers/media/firewire/firedtv-avc.c
> @@ -912,37 +912,6 @@ void avc_remote_ctrl_work(struct work_struct *work)
> avc_register_remote_control(fdtv);
> }
>
> -#if 0 /* FIXME: unused */
> -int avc_tuner_host2ca(struct firedtv *fdtv)
> -{
> - struct avc_command_frame *c = (void *)fdtv->avc_data;
> - int ret;
> -
> - mutex_lock(&fdtv->avc_mutex);
> -
> - c->ctype = AVC_CTYPE_CONTROL;
> - c->subunit = AVC_SUBUNIT_TYPE_TUNER | fdtv->subunit;
> - c->opcode = AVC_OPCODE_VENDOR;
> -
> - c->operand[0] = SFE_VENDOR_DE_COMPANYID_0;
> - c->operand[1] = SFE_VENDOR_DE_COMPANYID_1;
> - c->operand[2] = SFE_VENDOR_DE_COMPANYID_2;
> - c->operand[3] = SFE_VENDOR_OPCODE_HOST2CA;
> - c->operand[4] = 0; /* slot */
> - c->operand[5] = SFE_VENDOR_TAG_CA_APPLICATION_INFO; /* ca tag */
> - clear_operands(c, 6, 8);
> -
> - fdtv->avc_data_length = 12;
> - ret = avc_write(fdtv);
> -
> - /* FIXME: check response code? */
> -
> - mutex_unlock(&fdtv->avc_mutex);
> -
> - return ret;
> -}
> -#endif
> -
> static int get_ca_object_pos(struct avc_response_frame *r)
> {
> int length = 1;
> @@ -955,16 +924,6 @@ static int get_ca_object_pos(struct avc_response_frame *r)
>
> static int get_ca_object_length(struct avc_response_frame *r)
> {
> -#if 0 /* FIXME: unused */
> - int size = 0;
> - int i;
> -
> - if (r->operand[7] & 0x80)
> - for (i = 0; i < (r->operand[7] & 0x7f); i++) {
> - size <<= 8;
> - size += r->operand[8 + i];
> - }
> -#endif
> return r->operand[7];
> }
>
Hi Henrik,
get_ca_object_pos() is used in avc_ca_get_mmi() when the AVC response
frame is inspected. Do you know whether we should fix up this code for
support of length > 127, or can we just delete this #if 0 block?
--
Stefan Richter
-=====-===-= =--= ==---
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
