Hi Sakari,
Thank you for the patch.
On Thursday 19 September 2013 01:01:05 Sakari Ailus wrote:
> Pads that set this flag must be connected by an active link for the entity
> to stream.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
> Acked-by: Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx>
> ---
> Documentation/DocBook/media/v4l/media-ioc-enum-links.xml | 8 ++++++++
> include/uapi/linux/media.h | 1 +
> 2 files changed, 9 insertions(+)
>
> diff --git a/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml
> b/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml index
> 355df43..59b212a 100644
> --- a/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml
> +++ b/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml
> @@ -134,6 +134,14 @@
> <entry>Output pad, relative to the entity. Output pads source data
> and are origins of links.</entry>
> </row>
> + <row>
> + <entry><constant>MEDIA_PAD_FL_MUST_CONNECT</constant></entry>
> + <entry>A pad must be connected with an enabled link for the
s/A pad/The pad/ ?
> + entity to be able to stream. There could be temporary reasons
> + (e.g. device configuration dependent) for the pad to need
> + connecting; the absence of the flag won't say there
> + may not be any.</entry>
I believe the description doesn't make it very explicit that a MUST_CONNECT
pad with no existing link is valid, as opposed to existing links with no
enabled link, which would be invalid. Do you think we should fix that ?
> + </row>
> </tbody>
> </tgroup>
> </table>
> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
> index ed49574..d847c76 100644
> --- a/include/uapi/linux/media.h
> +++ b/include/uapi/linux/media.h
> @@ -98,6 +98,7 @@ struct media_entity_desc {
>
> #define MEDIA_PAD_FL_SINK (1 << 0)
> #define MEDIA_PAD_FL_SOURCE (1 << 1)
> +#define MEDIA_PAD_FL_MUST_CONNECT (1 << 2)
>
> struct media_pad_desc {
> __u32 entity; /* entity ID */
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
