Re: [RFC v1.2 2/4] media: Check for active links on pads with MEDIA_PAD_FL_MUST_CONNECT flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/18/2013 10:22 PM, Laurent Pinchart wrote:
Hi Sakari,

On Friday 06 September 2013 20:10:12 Sakari Ailus wrote:
>  On Fri, Sep 06, 2013 at 06:30:47PM +0200, Laurent Pinchart wrote:
>  >  On Wednesday 04 September 2013 03:09:42 Sakari Ailus wrote:
[...]
>  >  >  +			if (!(pad->flags&  MEDIA_PAD_FL_MUST_CONNECT)
>  >  >  +			    || link->flags&  MEDIA_LNK_FL_ENABLED)
>  >
>  >  With the || moved on the previous line (here and below),
>
>  I'd like to claim the above is more clear and conforms to GNU coding
>  standards whereas the kernel CodingStyle doesn't suggest either way:
>
>  <URL:http://www.gnu.org/prep/standards/standards.html#Formatting>

Quoting Documentation/CodingStyle:

"First off, I'd suggest printing out a copy of the GNU coding standards,
and NOT read it.  Burn them, it's a great symbolic gesture."

Oh, I like that one. It's all actually makes sense now. ;-)

--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux