Re: [PATCH 1/3] [media] siano: Don't show debug messages as errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 12 Sep 2013 16:59:58 -0300
Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx> wrote:

Tested-by: André Roth <neolynx@xxxxxxxxx>

> At this bugzilla and similar ones:
>    https://bugzilla.kernel.org/show_bug.cgi?id=60645
> 
> Those debug messages were seen as errors, but they're just debug
> data, and are OK to appear on sms1100 and sms2270. Re-tag them
> to appear only if debug is enabled.
> 
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>
> ---
>  drivers/media/common/siano/smscoreapi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/common/siano/smscoreapi.c b/drivers/media/common/siano/smscoreapi.c
> index a142f79..acf39ad 100644
> --- a/drivers/media/common/siano/smscoreapi.c
> +++ b/drivers/media/common/siano/smscoreapi.c
> @@ -982,7 +982,7 @@ static int smscore_load_firmware_family2(struct smscore_device_t *coredev,
>  	if (rc < 0)
>  		goto exit_fw_download;
>  
> -	sms_err("sending MSG_SMS_DATA_VALIDITY_REQ expecting 0x%x",
> +	sms_debug("sending MSG_SMS_DATA_VALIDITY_REQ expecting 0x%x",
>  		calc_checksum);
>  	SMS_INIT_MSG(&msg->x_msg_header, MSG_SMS_DATA_VALIDITY_REQ,
>  			sizeof(msg->x_msg_header) +
> @@ -1562,7 +1562,7 @@ void smscore_onresponse(struct smscore_device_t *coredev,
>  		{
>  			struct sms_msg_data *validity = (struct sms_msg_data *) phdr;
>  
> -			sms_err("MSG_SMS_DATA_VALIDITY_RES, checksum = 0x%x",
> +			sms_debug("MSG_SMS_DATA_VALIDITY_RES, checksum = 0x%x",
>  				validity->msg_data[0]);
>  			complete(&coredev->data_validity_done);
>  			break;
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux