Hi Frank, On Tue, 3 Sep 2013, Guennadi Liakhovetski wrote: > Hi Frank > > Thanks for testing! Let's have a look then: > > On Mon, 2 Sep 2013, Frank Schäfer wrote: > > > Am 28.08.2013 15:28, schrieb Guennadi Liakhovetski: > > > This patch series adds a V4L2 clock support to em28xx with an ov2640 > > > sensor. Only compile tested, might need fixing, please, test. > > > > > > Guennadi Liakhovetski (3): > > > V4L2: add v4l2-clock helpers to register and unregister a fixed-rate > > > clock > > > V4L2: add a v4l2-clk helper macro to produce an I2C device ID > > > V4L2: em28xx: register a V4L2 clock source > > > > > > drivers/media/usb/em28xx/em28xx-camera.c | 41 ++++++++++++++++++++++------- > > > drivers/media/usb/em28xx/em28xx-cards.c | 3 ++ > > > drivers/media/usb/em28xx/em28xx.h | 1 + > > > drivers/media/v4l2-core/v4l2-clk.c | 39 ++++++++++++++++++++++++++++ > > > include/media/v4l2-clk.h | 17 ++++++++++++ > > > 5 files changed, 91 insertions(+), 10 deletions(-) > > > > > > > Tested a few minutes ago: [snip] > > [ 104.321167] ------------[ cut here ]------------ > > [ 104.321216] WARNING: CPU: 0 PID: 517 at > > drivers/media/v4l2-core/v4l2-clk.c:131 v4l2_clk_disable+0x83/0x90 > > [videodev]() > > [ 104.321221] Unbalanced v4l2_clk_disable() on 11-0030:mclk! > > Ok, this is because em28xx_init_dev() calls > > /* Save some power by putting tuner to sleep */ > v4l2_device_call_all(&dev->v4l2_dev, 0, core, s_power, 0); > > without turning the subdevice on before. Are those subdevices on by > default? In principle, this warning is harmless and it should still work > afterwards, but we should still clean this up - by either removing the > warning, or adding a power-on before a power-off in em28xx_init_dev(), or > somehow else. In fact, I think, this should indeed be done: > em28xx_card_setup() performs i2c accesses, right? So, we have to power up > the subdev before that. Could you re-test with the .s_power() fixup patch I've sent several minutes ago? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
