re: [media] cx23885-dvb: use a better approach to hook set_frontend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Mauro Carvalho Chehab,

This is a semi-automatic email about new static checker warnings.

The patch 15472faf1259: "[media] cx23885-dvb: use a better approach
to hook set_frontend" from Aug 9, 2013, leads to the following Smatch
complaint:

drivers/media/pci/cx23885/cx23885-dvb.c:790 dvb_register()
	 error: we previously assumed 'fe0->dvb.frontend' could be null (see line 784)

drivers/media/pci/cx23885/cx23885-dvb.c
   783						       &i2c_bus->i2c_adap);
   784			if (fe0->dvb.frontend != NULL) {
                            ^^^^^^^^^^^^^^^^^^^^^^^^^
Existing check.

   785				dvb_attach(tda18271_attach, fe0->dvb.frontend,
   786					   0x60, &dev->i2c_bus[1].i2c_adap,
   787					   &hauppauge_hvr127x_config);
   788			}
   789			if (dev->board == CX23885_BOARD_HAUPPAUGE_HVR1275)
   790				cx23885_set_frontend_hook(port, fe0->dvb.frontend);
                                                                ^^^^^^^^^^^^^^^^^
Patch adds dereference.

   791			break;
   792		case CX23885_BOARD_HAUPPAUGE_HVR1255:

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux