On 08/26/2013 02:20 PM, Shaik Ameer Basha wrote: > Hi Sylwester, > > Thanks for the comments. > Please find the response inline... > > Actually, I am waiting for your comments only :) > are you also reviewing the driver code? If yes, I can delay the next > version until your post your comments. Yes, I've started reviewing the remaining patches. I just put this on my todo list with a bit lower priority since it is too late to have it in v3.12 anyway. I'll finish review today or tomorrow. It might be a good idea to hold on with posting new version until then. > On Sun, Aug 25, 2013 at 3:56 AM, Sylwester Nawrocki > <sylvester.nawrocki@xxxxxxxxx> wrote: >> On 08/19/2013 02:57 PM, Inki Dae wrote: >>>> >>>> -----Original Message----- >>>> From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media- >>>> owner@xxxxxxxxxxxxxxx] On Behalf Of Shaik Ameer Basha >>>> Sent: Monday, August 19, 2013 7:59 PM >>>> To: linux-media@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx >>>> Cc: s.nawrocki@xxxxxxxxxxx; posciak@xxxxxxxxxx; arun.kk@xxxxxxxxxxx; >>>> shaik.ameer@xxxxxxxxxxx >>>> Subject: [PATCH v2 4/5] [media] exynos-mscl: Add DT bindings for M-Scaler >>>> driver >>>> >>>> This patch adds the DT binding documentation for the exynos5 >> >> >> You may want to say to which specific SoC it applies. > > Ok. will update this. > Only 5410 and 5420 has this IP as of now. OK, good. >>>> based M-Scaler device driver. >>>> >>>> Signed-off-by: Shaik Ameer Basha<shaik.ameer@xxxxxxxxxxx> >>>> --- >>>> .../devicetree/bindings/media/exynos5-mscl.txt | 34 >>>> ++++++++++++++++++++ >>>> 1 file changed, 34 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/media/exynos5- >>>> mscl.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/exynos5-mscl.txt >>>> b/Documentation/devicetree/bindings/media/exynos5-mscl.txt >>>> new file mode 100644 >>>> index 0000000..5c9d1b1 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/media/exynos5-mscl.txt >>>> @@ -0,0 +1,34 @@ >>>> +* Samsung Exynos5 M-Scaler device >>>> + >>>> +M-Scaler is used for scaling, blending, color fill and color space >>>> +conversion on EXYNOS5 SoCs. >>>> + >>>> +Required properties: >>>> +- compatible: should be "samsung,exynos5-mscl" >> >> >> What is an exact name of this IP in the datasheet ? > > It is named as "SCALER". But when i got the Initial doc, it was also > known as memory to memory scaler. > so, i am using M-Scaler. > > Can i change this name to SCALER instead ? I think we should use names as they appear in the User Manuals, even though those might be overly generic. It shouldn't be difficult to identify an IP in a specific SoC. >>> If Exynos5410/5420 have same IP, >>> "samsung,exynos5410-mscl" for M Scaler IP in Exynos5410/5420" >>> >>> Else, >>> Compatible: should be one of the following: >>> (a) "samsung,exynos5410-mscl" for M Scaler IP in Exynos5410" >>> (b) "samsung,exynos5420-mscl" for M Scaler IP in Exynos5420" >> >> >> Yes, except I suspect "mscl" is incorrect. It sounds like an unclear >> abbreviation of real name of the IP. It likely should be "mscaler". >> >> >>>> +- reg: should contain M-Scaler physical address location and length. >>>> +- interrupts: should contain M-Scaler interrupt number >>>> +- clocks: should contain the clock number according to CCF >> >> >> Hmm, this sounds like a Linux specific term in the binding. Perhaps: >> >> - clocks: should contain the M-Scaler clock specifier, from the common >> clock bindings >> >> >> ? >>>> >>>> +- clock-names: should be "mscl" >>>> + >>>> +Example: >>>> + >>>> + mscl_0: mscl@0x12800000 { >> >> >> s/0x// > > Ok. Like this? > mscl_0: mscl@12800000 { Yup. >>>> + compatible = "samsung,exynos5-mscl"; >>> >>> >>> "samsung,exynos5410-mscl"; >>> >>>> + reg =<0x12800000 0x1000>; >>>> + interrupts =<0 220 0>; >>>> + clocks =<&clock 381>; >>>> + clock-names = "mscl"; >>>> + }; >>>> + >>>> +Aliases: >>>> +Each M-Scaler node should have a numbered alias in the aliases node, >>>> +in the form of msclN, N = 0...2. M-Scaler driver uses these aliases >>>> +to retrieve the device IDs using "of_alias_get_id()" call. >> >> >> So except in debug logs and for selecting variant data (which is same for >> all IP instances) are the aliases used for anything else ? >> I suspect you could do without these aliases. Device name includes start >> address of the IP register region, so that could be used to identify the >> M-Scaler instance in the logs. > > Ok. I will check more. > If it is only used for logs, then i will remove the aliases. Thanks. -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
