Re: [media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/23/2013 11:46 AM, Dan Carpenter wrote:
[ Going through some old warnings... ]

Hello Sylwester Nawrocki,

This is a semi-automatic email about new static checker warnings.

The patch babde1c243b2: "[media] V4L: Add driver for S3C24XX/S3C64XX
SoC series camera interface" from Aug 22, 2012, leads to the
following Smatch complaint:

drivers/media/platform/s3c-camif/camif-capture.c:463 queue_setup()
	 warn: variable dereferenced before check 'fmt' (see line 460)

drivers/media/platform/s3c-camif/camif-capture.c
    455          if (pfmt) {
    456                  pix =&pfmt->fmt.pix;
    457                  fmt = s3c_camif_find_format(vp,&pix->pixelformat, -1);
    458                  size = (pix->width * pix->height * fmt->depth) / 8;
                                                            ^^^^^^^^^^
Dereference.

    459		} else {
    460			size = (frame->f_width * frame->f_height * fmt->depth) / 8;
                                                                    ^^^^^^^^^^
Dereference.

    461		}
    462	
    463		if (fmt == NULL)
                     ^^^^^^^^^^^
Check.

Thanks for the bug report. This check of course should be before line 455.
Would you like to sent a patch for this or should I handle that ?

--
Regards,
Sylwester


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux