On 08/23/2013 11:35 AM, Dan Carpenter wrote: > Hello Sylwester Nawrocki, > > I had a question about 36fa80927638: "[media] s5p-csis: Add support for > non-image data packets capture" from Sep 21, 2012. > > S5PCSIS_INTSRC_NON_IMAGE_DATA is defined in mipi-csis.c: > > #define S5PCSIS_INTSRC_NON_IMAGE_DATA (0xff << 28) This is supposed to be a mask for bits [31:28], so (0xf << 28) > And it's only used in one place. > > drivers/media/platform/exynos4-is/mipi-csis.c > 692 u32 status; > 693 > 694 status = s5pcsis_read(state, S5PCSIS_INTSRC); > 695 spin_lock_irqsave(&state->slock, flags); > 696 > 697 if ((status & S5PCSIS_INTSRC_NON_IMAGE_DATA) && pktbuf->data) { > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > "status" is a u32 so 0xff0000000 is 4 bits too much. In other words, > the mask is effectively "(0xf << 28)". Was that intended or should it > be (0xff << 24)? It should be (0xf << 28). Thanks for looking into this. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html