Re: [RFCv2 PATCH 08/10] DocBook: document new v4l motion detection event.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Thursday 22 August 2013 08:38:59 Hans Verkuil wrote:
> On 08/21/2013 11:41 PM, Laurent Pinchart wrote:
> > On Monday 12 August 2013 12:58:31 Hans Verkuil wrote:
> >> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> >> 
> >> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> >> ---
> >> 
> >>  Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 40 ++++++++++++++++
> >>  .../DocBook/media/v4l/vidioc-subscribe-event.xml   |  9 +++++
> >>  2 files changed, 49 insertions(+)

[snip]

> >> diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> >> b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml index
> >> 5c70b61..d9c3e66 100644
> >> --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> >> +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> >> @@ -155,6 +155,15 @@
> >> 
> >>  	    </entry>
> >>  	  
> >>  	  </row>
> >>  	  <row>
> >> 
> >> +	    <entry><constant>V4L2_EVENT_MOTION_DET</constant></entry>
> >> +	    <entry>5</entry>
> >> +	    <entry>
> >> +	      <para>Triggered whenever the motion detection state changes, 
i.e.
> >> +	      whether motion is detected or not.
> > 
> > Isn't the event also triggered when region_mask changes from a non-zero
> > value to a different non-zero value ? The second part of the sentence
> > seems to imply that the even is only triggered when motion starts being
> > detected or stops being detected.
> 
> Good point. How about this:
> 
> "Triggered whenever the motion detection state for one or more of the
> regions changes."

That sounds good to me.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux