>Date: Thu, 11 Jul 2013 17:02:44 +0100
>From: Luis Alves <ljalvs@xxxxxxxxx>
>To: linux-media@xxxxxxxxxxxxxxx
>Cc: mchehab@xxxxxxxxxxxxx, crope@xxxxxx, Luis Alves <ljalvs@xxxxxxxxx>
>Subject: [PATCH] Fixed misleading error when handling IR interrupts.
>
>
>Hi,
>Handling the AV Core/IR interrupts schedules its workqueue but
>the schedule_work function returns false if @work was already on the
>kernel-global workqueue and true otherwise.
>
>Printing an error message if @work wasn't in the queue is wrong.
>
>Regards,
>Luis
>
Yes, the use of the return value is wrong (at least since 2.6.32). I must have misinterpreted the meaning of the return value when I added in that error message long ago.
Regards,
Andy
Acked-by: Andy Walls <awalls@xxxxxxxxxxxxxxxx>
>Signed-off-by: Luis Alves <ljalvs@xxxxxxxxx>
>---
> drivers/media/pci/cx23885/cx23885-core.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/drivers/media/pci/cx23885/cx23885-core.c
>b/drivers/media/pci/cx23885/cx23885-core.c
>index 268654a..9f63d93 100644
>--- a/drivers/media/pci/cx23885/cx23885-core.c
>+++ b/drivers/media/pci/cx23885/cx23885-core.c
>@@ -1941,10 +1941,7 @@ static irqreturn_t cx23885_irq(int irq, void
>*dev_id)
>
> if ((pci_status & pci_mask) & PCI_MSK_AV_CORE) {
> cx23885_irq_disable(dev, PCI_MSK_AV_CORE);
>- if (!schedule_work(&dev->cx25840_work))
>- printk(KERN_ERR "%s: failed to set up deferred work for"
>- " AV Core/IR interrupt. Interrupt is disabled"
>- " and won't be re-enabled\n", dev->name);
>+ schedule_work(&dev->cx25840_work);
> handled++;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
