On Saturday, August 03, 2013 12:19:54 AM you wrote: > Hello, > > > diff --git a/utils/qv4l2/Makefile.am b/utils/qv4l2/Makefile.am > > index 22d4c17..eed25b0 100644 > > --- a/utils/qv4l2/Makefile.am > > +++ b/utils/qv4l2/Makefile.am > > @@ -4,7 +4,8 @@ qv4l2_SOURCES = qv4l2.cpp general-tab.cpp ctrl-tab.cpp vbi-tab.cpp v4l2-api.cpp > > capture-win-qt.cpp capture-win-qt.h capture-win-gl.cpp capture-win-gl.h \ > > raw2sliced.cpp qv4l2.h capture-win.h general-tab.h vbi-tab.h v4l2-api.h raw2sliced.h > > nodist_qv4l2_SOURCES = moc_qv4l2.cpp moc_general-tab.cpp moc_capture-win.cpp moc_vbi-tab.cpp qrc_qv4l2.cpp > > -qv4l2_LDADD = ../../lib/libv4l2/libv4l2.la ../../lib/libv4lconvert/libv4lconvert.la ../libv4l2util/libv4l2util.la > > +qv4l2_LDADD = ../../lib/libv4l2/libv4l2.la ../../lib/libv4lconvert/libv4lconvert.la ../libv4l2util/libv4l2util.la \ > > + ../libmedia_dev/libmedia_dev.la > > > > if WITH_QV4L2_GL > > qv4l2_CPPFLAGS = $(QTGL_CFLAGS) -DENABLE_GL > > @@ -14,6 +15,12 @@ qv4l2_CPPFLAGS = $(QT_CFLAGS) > > qv4l2_LDFLAGS = $(QT_LIBS) > > endif > > > > +if WITH_QV4L2_ALSA > > +qv4l2_CPPFLAGS += $(ALSA_CFLAGS) -DENABLE_ALSA > > I would prefer if you don't add another define to the command line. To > check for ALSA support please include config.h and use the flag provided > there. That is fine for me. However, this design was to make the alsa code not compile in when not required. While I am at it, should I do the same for OpenGL, that is, remove WITH_QV4L2_GL with a config.h define)? The patch series has already been patched in, but I do have another series that adds features and fixes to the first OpenGL patches. It should not be a problem to change OpenGL accordingly as well. B. > > Thanks, > Gregor > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
