Hi Laurent, On Thu, Aug 01, 2013 at 12:48:39AM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Thursday 01 August 2013 00:29:21 Sakari Ailus wrote: > > On Wed, Jul 31, 2013 at 05:52:33PM +0200, Laurent Pinchart wrote: > > > From: Katsuya Matsubara <matsu@xxxxxxxxxx> > > > > > > Each source entity maintains a pointer to the counterpart sink > > > entity while an enabled link connects them. It should be managed by > > > the setup_link callback in the media controller framework at runtime. > > > However, enabled links which connect RPFs and WPFs that have an > > > equivalent index number are created during initialization. > > > This registers the pointer to a sink entity from the source entity > > > when an enabled link is created. > > > > > > Signed-off-by: Katsuya Matsubara <matsu@xxxxxxxxxx> > > > Signed-off-by: Laurent Pinchart > > > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > > --- > > > > > > drivers/media/platform/vsp1/vsp1_drv.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/media/platform/vsp1/vsp1_drv.c > > > b/drivers/media/platform/vsp1/vsp1_drv.c index b05aee1..4d338ce 100644 > > > --- a/drivers/media/platform/vsp1/vsp1_drv.c > > > +++ b/drivers/media/platform/vsp1/vsp1_drv.c > > > @@ -101,6 +101,9 @@ static int vsp1_create_links(struct vsp1_device *vsp1, > > > struct vsp1_entity *sink)> > > > entity, pad, flags); > > > > > > if (ret < 0) > > > return ret; > > > + > > > + if (flags & MEDIA_LNK_FL_ENABLED) > > > + source->sink = entity; > > > > "entity" here is in fact an entity which is a sink. It could have a more > > descriptive name. Up to you; should be changed in the 5th patch first. > > There's already a local variable called sink that points to the sink > vsp1_entity. entity points to the media_entity contained in the vsp1_entity. > Feel free to propose different names, otherwise I'll keep it as-is. How about sink_entity, for instance? But I'm fine with "entity", too. -- Cheers, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
