Hi Sakari,
Thank you for the review.
On Tuesday 30 July 2013 14:09:34 Sakari Ailus wrote:
> On Thu, Jul 25, 2013 at 03:00:12PM +0200, Laurent Pinchart wrote:
> > From: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> >
> > NV16M and NV61M are planar YCbCr 4:2:2 and YCrCb 4:2:2 formats with a
> > luma plane followed by an interleaved chroma plane. The planes are not
> > required to be contiguous in memory, and the formats can only be used
> > with the multi-planar formats API.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> > ---
> >
> > Documentation/DocBook/media/v4l/pixfmt-nv16m.xml | 170 ++++++++++++++++++
> > Documentation/DocBook/media/v4l/pixfmt.xml | 1 +
> > include/uapi/linux/videodev2.h | 2 +
> > 3 files changed, 173 insertions(+)
> > create mode 100644 Documentation/DocBook/media/v4l/pixfmt-nv16m.xml
> >
> > diff --git a/Documentation/DocBook/media/v4l/pixfmt-nv16m.xml
> > b/Documentation/DocBook/media/v4l/pixfmt-nv16m.xml new file mode 100644
> > index 0000000..84a8bb3
> > --- /dev/null
> > +++ b/Documentation/DocBook/media/v4l/pixfmt-nv16m.xml
> > @@ -0,0 +1,170 @@
> > + <refentry>
> > + <refmeta>
> > + <refentrytitle>V4L2_PIX_FMT_NV16M ('NM16'), V4L2_PIX_FMT_NV61M
> > ('NM61')</refentrytitle> + &manvol;
> > + </refmeta>
> > + <refnamediv>
> > + <refname
> > id="V4L2-PIX-FMT-NV16M"><constant>V4L2_PIX_FMT_NV16M</constant></refname>
> > + <refname
> > id="V4L2-PIX-FMT-NV61M"><constant>V4L2_PIX_FMT_NV61M</constant></refname>
> > + <refpurpose>Variation of <constant>V4L2_PIX_FMT_NV16</constant> and
> > <constant>V4L2_PIX_FMT_NV61</constant> with planes + non contiguous in
> > memory. </refpurpose>
> > + </refnamediv>
> > + <refsect1>
> > + <title>Description</title>
> > +
> > + <para>This is a multi-planar, two-plane version of the YUV 4:2:0
format.
> > +The three components are separated into two sub-images or planes.
> > +<constant>V4L2_PIX_FMT_NV16M</constant> differs from
> > <constant>V4L2_PIX_FMT_NV16 +</constant> in that the two planes are
> > non-contiguous in memory, i.e. the chroma +plane do not necessarily
> > immediately follows the luma plane.
> > +The luminance data occupies the first plane. The Y plane has one byte per
> > pixel. +In the second plane there is a chrominance data with alternating
> > chroma samples. +The CbCr plane is the same width and height, in bytes,
> > as the Y plane. +Each CbCr pair belongs to four pixels. For example,
> > +Cb<subscript>0</subscript>/Cr<subscript>0</subscript> belongs to
> > +Y'<subscript>00</subscript>, Y'<subscript>01</subscript>,
> > +Y'<subscript>10</subscript>, Y'<subscript>11</subscript>.
> > +<constant>V4L2_PIX_FMT_NV61M</constant> is the same as
> > <constant>V4L2_PIX_FMT_NV16M</constant> +except the Cb and Cr bytes are
> > swapped, the CrCb plane starts with a Cr byte.</para> +
> > + <para><constant>V4L2_PIX_FMT_NV16M</constant> is intended to be
> > +used only in drivers and applications that support the multi-planar API,
> > +described in <xref linkend="planar-apis"/>. </para>
>
> I think you could refer to V4L2_PIX_FMT_NV61M or alternatively move the
> sentence explaining V4L2_PIX_FMT_NV61M after the above. Up to you.
Something like
<para><constant>V4L2_PIX_FMT_NV16M</constant> and
<constant>V4L2_PIX_FMT_NV61M</constant> are intended to be used only in
drivers and applications that support the multi-planar API, described in
<xref linkend="planar-apis"/>. </para>
?
> Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxx>
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
