Hi Phil, On Mon, 29 Jul 2013, phil.edworthy@xxxxxxxxxxx wrote: > Hi Guennadi, > > > > Ok, now I see. My comment about the sensor output size changing is > wrong. > > > The sensor doesn't do any scaling, so we are cropping it. > > > > Ah, ok, then you shouldn't change video sizes in your .s_fmt(), just > > return the current cropping rectangle. > > I'm reworking the code but realised that the sensor _does_ do both scaling > and cropping. Though scaling is only possible by dropping every other scan > line when required height is <= 400 pixels. Right, the so called skipping. > So does that mean .s_fmt() should select the appropriate mode? You can use skipping to implement scaling, yes. But you don't have to. Drivers don't have to support all hardware capabilities, but what they do support they better do correctly :) So, it's up to you actually whether to add it now or later. Maybe it would be easier to get a basic version in the kernel now with no scaling support and add it later as an incremental patch. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
