Re: [REVIEW PATCH 4/6] exynos4-is: Add clock provider for the external clocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sylwester,

On Wed, Jul 24, 2013 at 12:09 AM, Sylwester Nawrocki
<s.nawrocki@xxxxxxxxxxx> wrote:
> This patch adds clock provider to expose the sclk_cam0/1 clocks
> for image sensor subdevs.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/media/samsung-fimc.txt     |   17 +++-
>  drivers/media/platform/exynos4-is/media-dev.c      |   92 ++++++++++++++++++++
>  drivers/media/platform/exynos4-is/media-dev.h      |   19 +++-
>  3 files changed, 125 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt
> index 96312f6..04a2b87 100644
> --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt
> +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt
> @@ -91,6 +91,15 @@ Optional properties
>  - samsung,camclk-out : specifies clock output for remote sensor,
>                        0 - CAM_A_CLKOUT, 1 - CAM_B_CLKOUT;
>
> +'clock-controller' node (optional)
> +----------------------------------
> +
> +The purpose of this node is to define a clock provider for external image
> +sensors and link any of the CAM_?_CLKOUT clock outputs with related external
> +clock consumer device. Properties specific to this node are described in
> +../clock/clock-bindings.txt.
> +
> +
>  Image sensor nodes
>  ------------------
>
> @@ -114,7 +123,7 @@ Example:
>                         vddio-supply = <...>;
>
>                         clock-frequency = <24000000>;
> -                       clocks = <...>;
> +                       clocks = <&camclk 1>;
>                         clock-names = "mclk";
>
>                         port {
> @@ -135,7 +144,7 @@ Example:
>                         vddio-supply = <...>;
>
>                         clock-frequency = <24000000>;
> -                       clocks = <...>;
> +                       clocks = <&camclk 0>;
>                         clock-names = "mclk";
>
>                         port {
> @@ -156,6 +165,10 @@ Example:
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&cam_port_a_clk_active>;
>
> +               camclk: clock-controller {
> +                      #clock-cells = 1;

Isn't it
                          #clock-cells = <1>;
?

> +               };
> +


Regards
Arun
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux