Re: [PATCH v2 1/8] [media] coda: use vb2_set_plane_payload instead of setting v4l2_planes[0].bytesused directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

Am Freitag, den 26.07.2013, 10:02 -0300 schrieb Mauro Carvalho Chehab:
> Hi Philipp,
> 
> Em Fri, 21 Jun 2013 09:55:27 +0200
> Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> escreveu:
> 
> > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> 
> Please provide a description of the patch.

Sorry, how about this:

"As stated in the vb2_buffer documentation, drivers should not directly fill
 in v4l2_planes[0].bytesused, but should use vb2_set_plane_payload()
 function instead. No functional changes."

regards
Philipp

> Thanks!
> Mauro
> 
> > ---
> >  drivers/media/platform/coda.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
> > index c4566c4..90f3386 100644
> > --- a/drivers/media/platform/coda.c
> > +++ b/drivers/media/platform/coda.c
> > @@ -1662,12 +1662,12 @@ static irqreturn_t coda_irq_handler(int irq, void *data)
> >  	wr_ptr = coda_read(dev, CODA_REG_BIT_WR_PTR(ctx->idx));
> >  	/* Calculate bytesused field */
> >  	if (dst_buf->v4l2_buf.sequence == 0) {
> > -		dst_buf->v4l2_planes[0].bytesused = (wr_ptr - start_ptr) +
> > -						ctx->vpu_header_size[0] +
> > -						ctx->vpu_header_size[1] +
> > -						ctx->vpu_header_size[2];
> > +		vb2_set_plane_payload(dst_buf, 0, wr_ptr - start_ptr +
> > +					ctx->vpu_header_size[0] +
> > +					ctx->vpu_header_size[1] +
> > +					ctx->vpu_header_size[2]);
> >  	} else {
> > -		dst_buf->v4l2_planes[0].bytesused = (wr_ptr - start_ptr);
> > +		vb2_set_plane_payload(dst_buf, 0, wr_ptr - start_ptr);
> >  	}
> >  
> >  	v4l2_dbg(1, coda_debug, &ctx->dev->v4l2_dev, "frame size = %u\n",
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux