Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 Hi Vladimir,

From: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
Date: Thu, 25 Jul 2013 10:55:51 +0400

> Hi  Matsubara-san,
> 
> On 07/25/2013 07:01 AM, Katsuya MATSUBARA wrote:
>>   Hi Vladimir,
>>
>>   Thank you for the revised patch.
>>
>> From: Sergei Shtylyov<sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>> Date: Sat, 20 Jul 2013 03:14:34 +0400
>>
>>> From: Vladimir Barinov<vladimir.barinov@xxxxxxxxxxxxxxxxxx>
>>>
>>> Add Renesas R-Car VIN (Video In) V4L2 driver.
>>>
>>> Based on the patch by Phil Edworthy<phil.edworthy@xxxxxxxxxxx>.
>>>
>>> Signed-off-by: Vladimir Barinov<vladimir.barinov@xxxxxxxxxxxxxxxxxx>
>>> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed
>>> 'enum chip_id'
>>> values, reordered rcar_vin_id_table[] entries, removed senseless
>>> parens from
>>> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {}
>>> to the
>>> *if* statement and used 'bool' values instead of 0/1 where necessary,
>>> *removed
>>> unused macros, done some reformatting and clarified some comments.]
>>> Signed-off-by: Sergei Shtylyov<sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>>>
>>> ---
>>> This patch is against the 'media_tree.git' repo.
>>>
>>> Changes since version 7:
>>> - remove 'icd' field from 'struct rcar_vin_priv' in accordance with the
>>> - commit
>>>    f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move
>>>    common code
>>>    to soc_camera.c);
>>> - added mandatory clock_{start|stop}() methods in accordance with the
>>> - commit
>>>    a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make
>>>    .clock_
>>>    {start,stop} compulsory, .add / .remove optional).
>> From: Vladimir Barinov<vladimir.barinov@xxxxxxxxxxxxxxxxxx>
>> Subject: Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver
>> Date: Sat, 22 Jun 2013 15:45:10 +0400
>>
>>>> But, captured images are still incorrect that means wrong
>>>> order of fields desite '_BT' chosen for V4L2_STD_525_60.
>>>>
>>> I've ordered the NTSC camera.
>>> I will return once I get it.
>>   Did you get an NTSC camera and see the field order issue
>>   occurs on your BOCK-W board?
> Yes I did.
>>   You may want to consider adding a workaround into
>>   the VIN driver if the issue remains in the latest patch.
> Have you seen this patch https://linuxtv.org/patch/19278/ ?

Oh, I missed the mail.
I tested it now and confirmed the issue has gone!

Thank you for fixing it.
---
Katsuya Matsubara / IGEL Co., Ltd
matsu@xxxxxxxxxx

 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux