Hi Ricardo, On 07/19/2013 09:58 AM, Ricardo Ribalda Delgado wrote: > Replace the private struct vb2_dma_sg_desc with the struct sg_table so > we can benefit from all the helping functions in lib/scatterlist.c for > things like allocating the sg or compacting the descriptor > > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> > --- [...] > diff --git a/include/media/videobuf2-dma-sg.h b/include/media/videobuf2-dma-sg.h > index 0038526..7b89852 100644 > --- a/include/media/videobuf2-dma-sg.h > +++ b/include/media/videobuf2-dma-sg.h > @@ -15,16 +15,10 @@ > > #include <media/videobuf2-core.h> > > -struct vb2_dma_sg_desc { > - unsigned long size; > - unsigned int num_pages; > - struct scatterlist *sglist; > -}; You need to squash patches 3/4, 4/4 into this one to avoid breaking build and git bisection. Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html