Hi Joe, On Thu, Jul 18, 2013 at 9:10 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Thu, 2013-07-18 at 20:59 +0530, Prabhakar Lad wrote: >> Use the dev_* message logging API instead of raw printk. > [] >> diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c > [] >> @@ -595,7 +595,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev) >> * matching with device name >> */ >> if (NULL == vpbe_dev || NULL == dev) { >> - printk(KERN_ERR "Null device pointers.\n"); >> + dev_err(dev, "Null device pointers.\n"); > > And if dev actually is NULL? > Ah nice catch, I overlooked it, I'll fix it. Regards, --Prabhakar -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html