On Wed, Jul 17, 2013 at 9:33 PM, Luis Alves <ljalvs@xxxxxxxxx> wrote: > Hi, > > This i2c init should stop the interrupt storm that happens in some cards when the IR receiver in enabled. > It works perfectly in my TBS6981. What is at I2C address 0x4c? Might be useful to have a comment in there explaining what this patch actually does. This assumes you know/understand what it does - if you don't then a comment saying "I don't know why this is needed but my board doesn't work right without it" is just as valuable. > It would be good to test in other problematic cards. > > In this patch I've added the IR init to the TeVii S470/S471 (and some others that fall in the same case statment). > Other cards but these that suffer the same issue should also be tested. Without fully understanding the nature of this patch and what cards that it actually effects, it may make sense to move your board into a separate case statement. Generally it's bad form to make changes like against other cards without any testing against those cards (otherwise you can introduce regressions). Stick it in its own case statement, and users of the other boards can move their cards into that case statement *after* it's actually validated. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
